Update mi test mi for region lock sfi #5538
Merged
+19
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace old MI client ID (3b57c42c-3201-4295-ae27-d6baec5b7027) with new MI (45344e7d-c562-4be6-868f-18dac789c021) - Replace old MI object ID (9fc6a41b-e161-43ba-90ba-12f172141c23) with new MI (a38637b6-b365-4652-af1f-cf5d8cf829ad) - Update resource ID from MSAL_MSI_USERID to Msal_Integration_tests - Update location from East US 2 to East US - Update readme.md documentation with new MI details and Azure portal links - All tests passing with new managed identity configuration
- Remove separate LabVaultAccessUserAssignedClientID (4b7a4b0b-ecb2-409e-879a-1e21a15ddaf6) - Update AcquireMsiToken_ExchangeForEstsToken_Successfully test to use consolidated UAMI - Use single UserAssignedClientID (45344e7d-c562-4be6-868f-18dac789c021) for both MSI and Key Vault access - Add documentation comments explaining the consolidation Note: Token exchange test requires federated identity credential in RequestMSIDLAB app registration
- Update ManagedIdentityImdsTests.cs to use ID4SMSIHostedAgent_UAMI - Client ID: 8ef2ae5a-f349-4d36-bc0e-a567f2cc50f7 - Object ID: 0651a6fc-fbf5-4904-9e48-16f63ec1f2b1 - Resource ID: /subscriptions/6f52c299-a200-4fe1-8822-a3b61cf1f931/resourcegroups/DevOpsHostedAgents/providers/Microsoft.ManagedIdentity/userAssignedIdentities/ID4SMSIHostedAgent_UAMI - Fixes pool access issues where E2E tests couldn't access the consolidated MI
- Change SAMI test to use explicit client ID instead of null - Resolves 'Multiple user assigned identities exist' error in IMDS - Maintains compatibility with main branch by keeping both UAMIs on pool - All 4 test cases now specify explicit identity parameters
gladjohn
reviewed
Oct 20, 2025
gladjohn
approved these changes
Oct 22, 2025
trwalke
approved these changes
Oct 22, 2025
…testing - Changed DataRow back from specific client ID to null /*SAMI*/, null - Restores proper SAMI test behavior instead of treating UAMI as SAMI - DisplayName changed back from 'SAMI-as-UAMI' to 'SAMI'
- Resolved merge conflict in ManagedIdentityImdsTests.cs - Preserved null SAMI test configuration for authentic system-assigned identity testing - Kept original client ID (8ef2ae5a-f349-4d36-bc0e-a567f2cc50f7) from branch for the fix - Adopted updated resource IDs and display names from main branch - Combined best of both branches: authentic SAMI testing with current lab infrastructure and original client ID fix
- Changed resource ID from main branch back to original branch values - Updated subscription ID: c1686c51-b717-4fe0-9af3-24a20a41fb0c -> 6f52c299-a200-4fe1-8822-a3b61cf1f931 - Updated resource group: MSAL_MSI -> DevOpsHostedAgents - Updated identity name: LabVaultAccess_UAMI -> ID4SMSIHostedAgent_UAMI - Ensures both client ID and resource ID fixes from original branch are preserved
- Updated Object ID from 1eee55b7-168a-46be-8d19-30e830ee9611 to 0651a6fc-fbf5-4904-9e48-16f63ec1f2b1 - Now all three test variants (ClientId, ResourceId, ObjectId) reference the same ID4SMSIHostedAgent_UAMI managed identity - Object ID matches the Principal ID of the created managed identity
gladjohn
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates Key Vault User Assigned Managed Identity (UAMI) and updates Managed Identity test infrastructure for improved reliability and maintainability.
Changes Made
🔧 Infrastructure Updates
4b7a4b0b-ecb2-409e-879a-1e21a15ddaf6)LabVaultAccess_UAMIto SLVM build agent for MI E2E test supportMSID_LABS_PPEsubscription for build agent inMSID_DEVX_RED_SBX📝 Code Changes
✅ Testing Results
🎯 Impact
Testing
Related Issues
Addresses MI E2E test failures in build pipelines by properly configuring required UAMI assignments.