Skip to content

Conversation

@bgavrilMS
Copy link
Member

Fixes #

Changes proposed in this request

Testing

Performance impact

Documentation

  • All relevant documentation is updated.

@bgavrilMS bgavrilMS requested a review from a team as a code owner June 25, 2025 19:15
Copy link
Member

@trwalke trwalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the full links to the features/bugs so the GitHub release has working links

image

@fengga
Copy link
Contributor

fengga commented Jun 25, 2025

NativeInterop in 0.18.2 - 0.19.1 has a regression that in some cases WAM ROPC flows may return ERROR_ADAL_ACCOUNT_AND_CREDENTIAL error. Our dotnet integration tests can repro the issue. And this issue is also impacting all the OneAuth users (we have too many regressions around that part).
0.19.2 fixed this issue, and PR #5362 updated NativeInterop from 0.18.1 to 0.19.2

0.19.2 also includes mac broker support, partners using microsoft.identity.client.broker 4.73.1 on mac can directly get NativeInterop 0.19.2

@fengga
Copy link
Contributor

fengga commented Jun 25, 2025

@trwalke, for PR #5274 I guess we don't have a github issue or feature, though I do have an ADO item https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3230941/ Will this work?

@bgavrilMS
Copy link
Member Author

Can you add the full links to the features/bugs so the GitHub release has working links

image

Can you add the full links to the features/bugs so the GitHub release has working links

image

Done, thanks.

@bgavrilMS bgavrilMS force-pushed the bgavrilMS-patch-1 branch from 10246a0 to f25e063 Compare July 2, 2025 14:05
@bgavrilMS
Copy link
Member Author

bgavrilMS commented Jul 2, 2025

@trwalke, for PR #5274 I guess we don't have a github issue or feature, though I do have an ADO item https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3230941/ Will this work?

It's really up to you how you want to handle the GitHub issues @fengga . We do recommend that you at least update the Changelog.md, as partners do look at those. I also recommend you try as much as possible to use the GitHub issues for bugs You'd be surprised how efficient search engines are at indexing GH issues, and implicitly helping others.

@bgavrilMS bgavrilMS force-pushed the bgavrilMS-patch-1 branch from f25e063 to 4b57b1f Compare July 9, 2025 11:06
@bgavrilMS bgavrilMS merged commit f665736 into main Jul 9, 2025
10 checks passed
@bgavrilMS bgavrilMS deleted the bgavrilMS-patch-1 branch July 9, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants