Stop replacing "%20" to "+" since it is obsoleted #5128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
too old and is obsoleted.
bgavrilMS
approved these changes
Feb 11, 2025
gladjohn
reviewed
Feb 11, 2025
gladjohn
reviewed
Feb 11, 2025
tests/Microsoft.Identity.Test.Unit/CoreTests/CoreHelperTests.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Feb 11, 2025
gladjohn
approved these changes
Feb 11, 2025
Co-authored-by: Gladwin Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5061 #5061
Changes proposed in this request
MSAL .NET is converting "openid%20profile%20offline_access" to "openid+profile+offline_access"
Partner prefers the original format since: "Some third party Identity Providers [namely Broadcom Siteminder] do NOT allow the usage of "+" to represent a space in URLs, in particular to separate scopes in the "authorize" endpoint."
“+” is defined in rfc1866 https://www.rfc-editor.org/rfc/rfc1866.txt made in 1995:
7.5. Queries and Indexes
The keywords are escaped according to [URL] and joined
by `+'.
rfc1866 is obsoleted by rfc2854 https://www.rfc-editor.org/rfc/rfc2854.txt made in 2000, while rfc2854 does not suggest using "+"
Testing
Performance impact
Documentation