Enhancing the logging within the ManagedIdentityClient class to provide more detailed information about the detection of managed identity sources. #5098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jan 23, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jan 28, 2025
gladjohn
force-pushed
the
gladjohn/log_fix
branch
from
9cacde7 to
f95e35c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5097
Changes proposed in this request
This pull request focuses on enhancing the logging within the
ManagedIdentityClientclass to provide more detailed information about the detection of managed identity sources. The most important changes include adding informative log messages at various points in the identity detection process and removing a redundant warning message.Enhancements to logging:
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs: Added log messages to indicate the detection of different managed identity sources, such as Service Fabric, App Service, Machine Learning, Cloud Shell, and Azure Arc.src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs: Added a log message to confirm the absence of certain managed identity sources before validating Azure Arc.Code cleanup:
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs: Removed a redundant warning message about Azure Arc managed identity configuration on non-Windows/Linux platforms.Testing
existing tests
Performance impact
none
Documentation