Add ML MSI Source #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gladjohn merged 6 commits into main from gladjohn/ml_msi

Jan 9, 2025

Contributor

gladjohn commented Jan 6, 2025 •

edited by Robbie-Microsoft

Loading

Fixes #4984

Changes proposed in this request

Add ML MSI Source

Testing

Unit tests

Performance impact
none

Documentation

All relevant documentation is updated.

neha-bhargava reviewed

View reviewed changes

src/client/Microsoft.Identity.Client/ManagedIdentity/MachineLearningManagedIdentitySource.cs Outdated Show resolved Hide resolved

neha-bhargava reviewed

View reviewed changes

src/client/Microsoft.Identity.Client/ManagedIdentity/MachineLearningManagedIdentitySource.cs Outdated Show resolved Hide resolved

neha-bhargava reviewed

View reviewed changes

src/client/Microsoft.Identity.Client/ManagedIdentity/MachineLearningManagedIdentitySource.cs Outdated Show resolved Hide resolved

neha-bhargava reviewed

View reviewed changes

tests/Microsoft.Identity.Test.Common/Core/Mocks/MockHttpManagerExtensions.cs Outdated Show resolved Hide resolved

neha-bhargava reviewed

View reviewed changes

Contributor

neha-bhargava left a comment

Some minor comments otherwise looks good. Were you able to test the flow manually? Is it documented how you did the manual testing?

gladjohn changed the title ~~[DRAFT] ML MSI~~ Add ML MSI Source

gladjohn marked this pull request as ready for review

January 7, 2025 05:59

gladjohn requested a review from a team as a code owner

January 7, 2025 05:59

bgavrilMS requested review from 4gust and AndyOHart

January 7, 2025 13:39

Member

bgavrilMS commented Jan 7, 2025

@AndyOHart @4gust - please review this, it shows how to integrate the ML host.
@gladjohn - did you test this or is it based on Azure SDK implementation + unit tests? If you tested, can you share the test setup with Andy and Nilesh?

Contributor Author

gladjohn commented Jan 7, 2025

@gladjohn - did you test this or is it based on Azure SDK implementation + unit tests? If you tested, can you share the test setup with Andy and Nilesh?

I just filed a task with the lab to create some ML resources to test it. Will document the test setup once I have them. As of now this is based on unit tests.

4gust approved these changes

View reviewed changes

Contributor

4gust left a comment

Looks good to me

AndyOHart approved these changes

View reviewed changes

AndyOHart left a comment

LGTM :)

christothes reviewed

View reviewed changes

src/client/Microsoft.Identity.Client/ManagedIdentity/MachineLearningManagedIdentitySource.cs Show resolved Hide resolved

gladjohn force-pushed the gladjohn/ml_msi branch from e4bc7b2 to 6d34795 Compare

January 8, 2025 05:52

GladwinJohnson and others added 5 commits

January 9, 2025 06:34

ese

18414e0

nit

Update ManagedIdentity environment variables and add MachineLearning source#	src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt


          pr comments

e357c26


          Update src/client/Microsoft.Identity.Client/ManagedIdentity/MachineLe…

d120da5

…arningManagedIdentitySource.cs

Co-authored-by: Neha Bhargava <[email protected]>


          tests

8e61f6d


          Metadata

f3a93ee

gladjohn force-pushed the gladjohn/ml_msi branch from 6d34795 to f3a93ee Compare

January 9, 2025 14:42


          improve tests

neha-bhargava approved these changes

View reviewed changes

gladjohn merged commit 03f4b6d into main

6 checks passed

gladjohn deleted the gladjohn/ml_msi branch

January 9, 2025 18:55

christothes mentioned this pull request

Support Azure Machine Learning managed identity Azure/azure-sdk-for-net#40348

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet