Fix bug in MeasureDurationResult #5035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Dec 31, 2024
bgavrilMS
force-pushed
the
akaliugonna/stopwatchservice
branch
from
03696fa to
8b4f9cd
Compare
Member
|
Much appreciated @Ugonnaak1 ! |
gladjohn
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4895 and #5036
Changes proposed in this request
Updated the MeasureDurationResult class to properly measure milliseconds and microseconds so that the measuredurationresult accurately reflects the total elapsed time without being limited by the modulus operator
Testing
Used the sample app to ensure that stopwatch measured time aligned with the durationtotalinms within the authenticationresultmetadata when there is a change of scopes
Performance impact
Documentation