Add the public API analyzer #5009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
force-pushed
the
bogavril/api_analyzer
branch
from
5f40b82 to
970ab30
Compare
|
Shouldn't the "Desktop, Broker, Extension" projects also have a separate folder for each target framework? |
trwalke
approved these changes
Dec 6, 2024
neha-bhargava
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Did you also consider adding Nullable reference type support?
bgavrilMS
force-pushed
the
bogavril/api_analyzer
branch
from
970ab30 to
e2759ad
Compare
|
Well MSAL doesn't use nullable references feature. We can add it, but that's a work item in itself and a I imagine pretty big one. |
|
|
Ignoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4931
Changes proposed in this request
Testing
Performance impact
Documentation