WithBroker(true) now fails at build time, not at runtime #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trwalke
reviewed
May 16, 2024
src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
trwalke
approved these changes
May 16, 2024
…licationBuilder.cs Co-authored-by: Travis Walker <[email protected]>
neha-bhargava
approved these changes
May 16, 2024
gladjohn
approved these changes
May 16, 2024
src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
Show resolved
Hide resolved
…licationBuilder.cs Co-authored-by: Travis Walker <[email protected]>
bgavrilMS
force-pushed
the
bogavril/net6win_feedback
branch
from
a3ea696
to
ff8f772
Compare
…licationBuilder.cs Co-authored-by: Gladwin Johnson <[email protected]>
|
Only some ADFS tests are failing, due to lab issue. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4768
We received feedback that after removing net6-windows tfm, apps fail at runtime due to using old broker API. It would be better if they fail at build time.