Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Xamarin #4706

Merged
merged 13 commits into from
Apr 19, 2024
Merged

Remove Xamarin #4706

merged 13 commits into from
Apr 19, 2024

Conversation

bgavrilMS
Copy link
Member

@bgavrilMS bgavrilMS commented Apr 10, 2024 •
edited by pmaytak
Loading

Fixes #4715

Remove Xamarin!!

pmaytak
pmaytak requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

src/client/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj Outdated Show resolved Hide resolved
src/client/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj Outdated Show resolved Hide resolved
Directory.Packages.props Show resolved Hide resolved
@pmaytak
Copy link
Contributor

pmaytak commented Apr 16, 2024

@bgavrilMS Does this branch build for you locally? Fails to build for me and installing MAUI workloads also fails (can't find some dependency in the feeds....). :(

@pmaytak pmaytak changed the title Bogavril/xamarin removal Remove Xamarin Apr 16, 2024
@bgavrilMS
Copy link
Member Author

@bgavrilMS Does this branch build for you locally? Fails to build for me and installing MAUI workloads also fails (can't find some dependency in the feeds....). :(

No, it fails for me too due to old .NET SDK. I ended up using net7-android / net7-ios to verify the build etc.

I was thinking of bumping to net7-*** althoghter, but it's not trivial - there are some APIs which are now obsolete and I don't have a full Android / iOS setup to test. We can revisit this if it causes build issues on the lab.

@bgavrilMS bgavrilMS requested a review from pmaytak April 16, 2024 16:19
pmaytak
pmaytak previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

trwalke
trwalke reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@trwalke trwalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Longer needed?

microsoft-authentication-library-for-dotnet/LibsAndSamples.sln

Line 138 in 4a8c4dd

Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "IntuneMAMSampleiOS", "tests\devapps\Intune-xamarin-ios\IntuneMAMSampleiOS.csproj", "{034A5B86-A8AE-449D-B561-46F811329E6D}"

trwalke
trwalke reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@trwalke trwalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we still need LibsMacOS.sln

trwalke
trwalke reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@trwalke trwalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer need template-build-android-automation.yaml

Base automatically changed from bogavril/net6win_removal to main April 18, 2024 12:50
@bgavrilMS bgavrilMS dismissed pmaytak’s stale review April 18, 2024 12:50

The base branch was changed.

@bgavrilMS bgavrilMS requested a review from a team as a code owner April 18, 2024 12:50
gladjohn
gladjohn approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@gladjohn gladjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Can we also delete the Automation framework / subscription we used to have to run Android and IOS tests? Do not remember the name now just making sure we do the clean up of that if not required anymore

Directory.Packages.props Show resolved Hide resolved
@bgavrilMS
Copy link
Member Author

looks good. Can we also delete the Automation framework / subscription we used to have to run Android and IOS tests? Do not remember the name now just making sure we do the clean up of that if not required anymore

For sure. I don't know where it is though... @trwalke ?

@bgavrilMS bgavrilMS merged commit d3d64ba into main Apr 19, 2024
6 checks passed
@bgavrilMS bgavrilMS deleted the bogavril/xamarin_removal branch April 19, 2024 09:22
trwalke pushed a commit that referenced this pull request Jun 17, 2024
@bgavrilMS
Remove Xamarin (#4706)
6dd9838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trwalke trwalke trwalke approved these changes

@pmaytak pmaytak pmaytak approved these changes

@neha-bhargava neha-bhargava neha-bhargava approved these changes

@gladjohn gladjohn gladjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove Xamarin targets
5 participants
@bgavrilMS @pmaytak @trwalke @neha-bhargava @gladjohn