Remove net6win #4567
Merged
Remove net6win #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
gladjohn,
neha-bhargava,
pmaytak and
trwalke
bgavrilMS
force-pushed
the
bogavril/net6win_removal
branch
2 times, most recently
from
626235d
to
912bd36
Compare
pmaytak
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Looks good. Anymore changes that need to be done?
Any way we can update exceptions in the code with more details related to this change? If net6.0-windows PCA app gets updated to the new MSAL version, standard exceptions will be thrown to use Broker or Desktop packages; but if the user didn't read the release notes, it'll be unclear why the change happened.
src/client/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.Win8/BrokerOnWin8Tests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/Kerberos/KerberosSupplementalTicketManagerTests.cs
Outdated
Show resolved
Hide resolved
SimonCropp
reviewed
Jan 24, 2024
src/client/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj
Outdated
Show resolved
Hide resolved
SimonCropp
reviewed
Jan 24, 2024
trwalke
reviewed
Jan 26, 2024
tests/Microsoft.Identity.Test.Integration.Win8/BrokerOnWin8Tests.cs
Outdated
Show resolved
Hide resolved
trwalke
reviewed
Jan 26, 2024
tests/Microsoft.Identity.Test.Unit/AppConfigTests/PublicClientApplicationBuilderTests.cs
Show resolved
Hide resolved
trwalke
approved these changes
Jan 26, 2024
|
so for people are targeting |
bgavrilMS
force-pushed
the
bogavril/net6win_removal
branch
from
842a7f4
to
7cae0eb
Compare
|
@bgavrilMS so it this a breaking change? #4567 (comment) |
bgavrilMS
force-pushed
the
bogavril/net6win_removal
branch
from
7cae0eb
to
83ebad4
Compare
|
@bgavrilMS Are these 3 PRs ready for review (this, uwp, xamarin removal)? |
|
Yes, we discussed with @localden about removing UWP. Xamarin goes out of support May 1st. And we discussed about net6-win too. |
pmaytak
requested changes
Apr 16, 2024
src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenInteractiveParameterBuilder.cs
Show resolved
Hide resolved
pmaytak
reviewed
Apr 18, 2024
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenInteractiveParameterBuilder.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
Apr 18, 2024
src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
|
Created an docs issue to update the docs: MicrosoftDocs/microsoft-authentication-library-dotnet#395 |
…eractiveParameterBuilder.cs Co-authored-by: Peter <[email protected]>
…licationBuilder.cs Co-authored-by: Peter <[email protected]>
trwalke
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Attempt * fix * fix * Remove NET_ONLY * Adress PR comments * Address PRs * Update src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenInteractiveParameterBuilder.cs Co-authored-by: Peter <[email protected]> * Update src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs Co-authored-by: Peter <[email protected]> --------- Co-authored-by: Peter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4468
And this PR updates the sample (also bumps it to net7, because net6 is out of support)
Azure-Samples/ms-identity-dotnetcore-maui#16