Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding null IdentityLogger to prevent null reference when using cache logger #3678

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Adding null IdentityLogger to prevent null reference when using cache logger #3678

merged 4 commits into from
Sep 16, 2022

Conversation

trwalke
Copy link
Member

@trwalke trwalke commented Sep 15, 2022

Fixes #
Prevents null reference when no logger is set on the client app and logging is enabled on the token cache notification args

Changes proposed in this request
Adding null IdentityLogger to null logger

Testing
Unit test

Performance impact
N/A

Documentation

  • All relevant documentation is updated.

neha-bhargava
neha-bhargava approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@neha-bhargava neha-bhargava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@trwalke trwalke mentioned this pull request Sep 16, 2022
Merged
1 task
@trwalke trwalke changed the title Adding null IdentityLogger Adding null IdentityLogger to prevent null reference when using cache logger Sep 16, 2022
jmprieur
jmprieur approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @trwalke

src/client/Microsoft.Identity.Client/Internal/Logger/NullIdentityLogger.cs Outdated Show resolved Hide resolved
@trwalke trwalke enabled auto-merge (squash) September 16, 2022 03:27
@trwalke trwalke merged commit 75de81e into main Sep 16, 2022
@trwalke trwalke deleted the trwalke/IdentityNullLoggerFix branch September 16, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gladjohn gladjohn gladjohn approved these changes

@neha-bhargava neha-bhargava neha-bhargava approved these changes

@pmaytak pmaytak pmaytak approved these changes

@jmprieur jmprieur jmprieur approved these changes

@SameerK-MSFT SameerK-MSFT Awaiting requested review from SameerK-MSFT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trwalke @jmprieur @pmaytak @neha-bhargava @gladjohn