Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetAccountAsync fix by checking for null on accountId #3118

Merged
merged 3 commits into from
Jan 20, 2022
Merged

GetAccountAsync fix by checking for null on accountId #3118

merged 3 commits into from
Jan 20, 2022

Conversation

gladjohn
Copy link
Contributor

Fixes #

Changes proposed in this request
GetAccountAsync fix by checking for null on accountId

Testing
unit tests

Performance impact
n/a

@gladjohn gladjohn marked this pull request as ready for review January 20, 2022 07:08
trwalke
trwalke approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@trwalke trwalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good gladwin

@gladjohn gladjohn merged commit 8322b38 into master Jan 20, 2022
@gladjohn gladjohn deleted the gladjohn/getaccountfix1 branch January 20, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trwalke trwalke trwalke approved these changes

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava

@SameerK-MSFT SameerK-MSFT Awaiting requested review from SameerK-MSFT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gladjohn @bgavrilMS @trwalke @GladwinJohnson