Throw a friendly exception instead of NullRef for regional scenario. … #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
reviewed
Oct 19, 2021
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ClientCredentialWithRegionTests.cs
Outdated
Show resolved
Hide resolved
jennyf19
approved these changes
Oct 19, 2021
pmaytak
approved these changes
Oct 20, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…See #2837
Provides a better experience (friendly exception instead of null ref) for #2837, but doesn't fully fix it.
Changes proposed in this request
Regional has different rules for instance discovery, so we can't check if the request authority is an alias of the app authority.
Proposal is to ask developers to use
WithTenantIdinstead.Testing
unit
Performance impact
negligible (1 extra string comparison)