Added Tenant ID to WwwAuthenticateParameters #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abatishchev
force-pushed
the
alexbat/www-auth-2
branch
from
8db5608
to
a3a96d2
Compare
bgavrilMS
reviewed
Oct 4, 2021
bgavrilMS
reviewed
Oct 4, 2021
...t.Identity.Test.Integration.netfx/HeadlessTests/WwwAuthenticateParametersIntegrationTests.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 4, 2021
bgavrilMS
approved these changes
Oct 4, 2021
abatishchev
force-pushed
the
alexbat/www-auth-2
branch
from
a3a96d2
to
80154b5
Compare
abatishchev
force-pushed
the
alexbat/www-auth-2
branch
from
80154b5
to
b272556
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jmprieur
reviewed
Oct 6, 2021
There was a problem hiding this comment.
LGTM
Thanks @abatishchev
One feedback/comment for @bgavrilMS
src/client/Microsoft.Identity.Client/WwwAuthenticateParameters.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/WwwAuthenticateParameters.cs
Outdated
Show resolved
Hide resolved
pmaytak
approved these changes
Oct 6, 2021
tests/Microsoft.Identity.Test.Unit/WwwAuthenticateParametersTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/WwwAuthenticateParametersTests.cs
Outdated
Show resolved
Hide resolved
trwalke
approved these changes
Oct 6, 2021
bgavrilMS
reviewed
Oct 6, 2021
src/client/Microsoft.Identity.Client/WwwAuthenticateParameters.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
requested changes
Oct 6, 2021
jmprieur
reviewed
Oct 7, 2021
| /// <summary> | ||
| /// Gets Azure AD tenant ID. | ||
| /// </summary> | ||
| public string GetTenantId() => Instance.Authority |
There was a problem hiding this comment.
Yes. If we want to rip it up into a different package, we can either:
- not take this method along and instead make it into an extension method to avoid any breaking changes in MSAL
OR - move
GetTenantIdto the new package, but provide a different implementation for it.
There was a problem hiding this comment.
@bgavrilMS @jmprieur Following up on this - are we taking this as-is or refactoring needed before release?
There was a problem hiding this comment.
I think it's fine as is for now. If we introduce support for other authorities, this will have to return null. If we need to extract a package from this logic, we can leave this method behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this request
TenantIDtoWwwAuthenticateParametersAuthorityto parseauthority uriTesting
Performance impact