Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Supportability Bug] Deprecate WithClientAssertion(string) as it leads to assertion expiration issues #4775

Closed
bgavrilMS opened this issue May 21, 2024 · 0 comments · Fixed by #4776
Closed

[Supportability Bug] Deprecate WithClientAssertion(string) as it leads to assertion expiration issues #4775

bgavrilMS opened this issue May 21, 2024 · 0 comments · Fixed by #4776
Labels
bug confidential-client P2 Supportability

Comments

@bgavrilMS
Copy link
Member

Library version used

4.60

.NET version

all

Scenario

ConfidentialClient - web site (AcquireTokenByAuthCode), ConfidentialClient - web api (AcquireTokenOnBehalfOf), ConfidentialClient - service to service (AcquireTokenForClient)

Is this a new or an existing app?

None

Issue description and reproduction steps

We keep getting feedback that WithClientAssert(string) causes expiration issues.

Relevant code snippets

No response

Expected behavior

No response

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

No response
@bgavrilMS bgavrilMS added untriaged Do not delete. Needed for Automation needs attention Delete label after triage bug P2 Supportability confidential-client and removed untriaged Do not delete. Needed for Automation needs attention Delete label after triage labels May 21, 2024
bgavrilMS added a commit that referenced this issue May 21, 2024
@bgavrilMS
Fix for #4775 - deprecate WithClientAssertion(string)
7cb626a
@bgavrilMS bgavrilMS mentioned this issue May 21, 2024
Merged
@Avery-Dunn Avery-Dunn mentioned this issue May 21, 2024
Open
gladjohn added a commit that referenced this issue May 21, 2024
@bgavrilMS @neha-bhargava @gladjohn
Fix for #4775 - deprecate WithClientAssertion(string) (#4776)
01050f5 
* Fix for #4775 - deprecate WithClientAssertion(string)

* Update src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs

* Apply suggestions from code review

---------

Co-authored-by: Neha Bhargava <[email protected]>
Co-authored-by: Gladwin Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confidential-client P2 Supportability
Projects
None yet
Milestone
No milestone
1 participant
@bgavrilMS