Fix the back-compat of hello() #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the helper function getHelloResultFromBundle
rpdome
reviewed
Aug 23, 2019
common/src/main/java/com/microsoft/identity/common/internal/result/MsalBrokerResultAdapter.java
Outdated
Show resolved
Hide resolved
kreedula
reviewed
Aug 23, 2019
common/src/main/java/com/microsoft/identity/common/internal/result/MsalBrokerResultAdapter.java
Outdated
Show resolved
Hide resolved
kreedula
reviewed
Aug 23, 2019
common/src/main/java/com/microsoft/identity/common/internal/result/MsalBrokerResultAdapter.java
Outdated
Show resolved
Hide resolved
kreedula
approved these changes
Aug 23, 2019
rpdome
reviewed
Aug 23, 2019
common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerResult.java
Show resolved
Hide resolved
rpdome
approved these changes
Aug 23, 2019
heidijinxujia
added a commit
that referenced
this pull request
Aug 29, 2019
* dev: Handle the app installation link for browser flow (#611) Correcting javadoc (#610) Fix the back-compat of hello() (#606) Closes #607, #604 (#608) Adds implementation for OpenIdConfig (#605) Add PCA initialization error strings (#598) Change log update Do not load access tokens from foci cache fallback logic (#599) Update to 0.0.16 (#596) Add clearBrokerSecretKeys() (#595) Fix for foci lookups relative to migration (#594) Change telemetry type from 'session' to 'event' (#592)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unused property in BrokerResult
Add the helper function getHelloResultFromBundle