First pass, app registry implementation #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kreedula
reviewed
Aug 13, 2019
.../com/microsoft/identity/common/internal/cache/registry/DefaultBrokerApplicationRegistry.java
Outdated
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
.../src/main/java/com/microsoft/identity/common/internal/cache/AbstractApplicationMetadata.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
common/src/main/java/com/microsoft/identity/common/internal/cache/ISimpleCache.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
...main/java/com/microsoft/identity/common/internal/cache/SharedPreferencesSimpleCacheImpl.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
...ava/com/microsoft/identity/common/internal/cache/registry/BrokerApplicationRegistryData.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
.../com/microsoft/identity/common/internal/cache/registry/DefaultBrokerApplicationRegistry.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
...n/java/com/microsoft/identity/common/internal/cache/registry/IBrokerApplicationRegistry.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
.../src/main/java/com/microsoft/identity/common/internal/cache/AbstractApplicationMetadata.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
.../src/main/java/com/microsoft/identity/common/internal/cache/AbstractApplicationMetadata.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
...main/java/com/microsoft/identity/common/internal/cache/SharedPreferencesSimpleCacheImpl.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
...ava/com/microsoft/identity/common/internal/cache/registry/BrokerApplicationRegistryData.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
.../com/microsoft/identity/common/internal/cache/registry/DefaultBrokerApplicationRegistry.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
...n/java/com/microsoft/identity/common/internal/cache/registry/IBrokerApplicationRegistry.java
Show resolved
Hide resolved
iambmelt
commented
Aug 15, 2019
...main/java/com/microsoft/identity/common/internal/cache/SharedPreferencesSimpleCacheImpl.java
Show resolved
Hide resolved
base class, that hashCode() and equals() must be regenerated
kreedula
approved these changes
Aug 15, 2019
heidijinxujia
added a commit
that referenced
this pull request
Aug 19, 2019
* dev: (33 commits) First pass, app registry implementation (#591) Use the junit version declared in versions.gradle (#588) Adding junit version declaration to versions.gradle (#587) Update Travis-CI build SDK version 27 -> 28, Fix AndroidX Compat (#581) Throttle Telemetry with Shared pref on broker switch (#583) Version + change log update Set the InteractiveTokenCommand to null once it has finished (#580) Updated log Formatting changes Adding null safety check to avoid crash if broadcast is sent multiple times Migrate to AndroidX (#575) Removing commented out line (#578) Change log update Version update to remove RC Read user info id from the request bundle on silent request (#574) New CI config (#573) Adding flexibility around pwd_exp return type, string, int, long (#572) Disabling tests on travis Change log update Bump common version to 0.0.12 ... # Conflicts: # common/src/main/java/com/microsoft/identity/common/internal/controllers/ExceptionAdapter.java # common/versioning/version.properties
heidijinxujia
added a commit
that referenced
this pull request
Aug 21, 2019
* dev: First pass, app registry implementation (#591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass implementation, requires cleanup + comments.