-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the telemetry events #565
Merged
Merged
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
868dc96
Update the api events and add constants for telemetry string.
heidijinxujia 70f5141
Integrate UI events
heidijinxujia 7d1577b
Merge branch 'dev' into jinjia/apiEvents
heidijinxujia 745777a
Add the events.
heidijinxujia 5540e4c
Merge branch 'dev' into jinjia/apiEvents
heidijinxujia c5c5f37
Update events and constants
heidijinxujia 1dee216
Update the constants to align with ADAL
heidijinxujia e150971
Fix the counting and updated fields to align with ADAL telemetry
heidijinxujia 9cb168d
Merge branch 'dev' into jinjia/apiEvents
heidijinxujia 4955d8e
To fix the broker NPE caused by common telemetry.
heidijinxujia 8f042ae
Remove unused code and constants.
heidijinxujia 4dad4b5
Resolve pmd
heidijinxujia b529270
Add the MRRT status as TRUE by default.
heidijinxujia 56b32f3
Merge branch 'dev' into jinjia/apiEvents
heidijinxujia 795a62c
Address Brian's comments.
heidijinxujia 9a904d2
Address the comments
heidijinxujia 0865c8b
Merge branch 'dev' into jinjia/apiEvents
heidijinxujia 17f6f77
Address the comments.
heidijinxujia e34b893
Merge branch 'dev' into jinjia/apiEvents
heidijinxujia 1b5eb34
Address the comments.
heidijinxujia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be misleading? (as 'true' here means Broker app is in standby - it doesn't necessary means that power optimization is on).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aim of this function
isNetworkDisabledFromOptimizations()
is to check if the network is not functional because of power optimization.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that the same for telemetry event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The telemetry here is to track the power optimization is on. The telemetry for the network unavailable is in the calling method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if you prefer another naming of the property.