Skip to content

Adding explicit unlocking using portalocker #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhidnya13 merged 7 commits into from
Apr 10, 2020
Merged

Adding explicit unlocking using portalocker #43

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
60fcefd
Adding explicit unlocking using portalocker
abhidnya13 Mar 27, 2020
790fc2a
Updating setup file
abhidnya13 Mar 28, 2020
a9a00e8
building on top of portlocker Lock
abhidnya13 Apr 9, 2020
82c8074
changing variable name for pylint
abhidnya13 Apr 9, 2020
eac8a61
Changing locking flags
abhidnya13 Apr 10, 2020
34beb50
Fixing pylint issues
abhidnya13 Apr 10, 2020
a53a655
Update msal_extensions/cache_lock.py
abhidnya13 Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions msal_extensions/cache_lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def __enter__(self):
self._fh.write('{} {}'.format(pid, sys.argv[0]).encode('utf-8'))

def __exit__(self, *args):
portalocker.unlock(self._fh)
self._fh.close()
try:
# Attempt to delete the lockfile. In either of the failure cases enumerated below, it is
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
package_data={'': ['LICENSE']},
install_requires=[
'msal>=0.4.1,<2.0.0',
'portalocker~=1.0',
'portalocker~=1.6',
],
tests_require=['pytest'],
)