Repository navigation
Pin patched REST client runtime on dev5x - #3634
Merged
Merged
Conversation
Override the vulnerable Microsoft.Azure.KeyVault transitive dependency with Microsoft.Rest.ClientRuntime 2.3.24 so audited solution pack succeeds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fcfe8afe-98a1-4fae-800d-b0a2550232b2
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Avery-Dunn
approved these changes
Sep 14, 2026
Peter (pmaytak)
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dev5x
Build and pack Wilson for ID Web E2E teststask runsdotnet pack Wilson.sln, which restores test projects with NuGet audit enabled.Microsoft.Azure.KeyVault 3.0.0resolvesMicrosoft.Rest.ClientRuntime 2.3.11, which is affected by GHSA-whph-446h-6m9v. Because the repository treats warnings as errors, NU1902 stops the pack.This change pins
Microsoft.Rest.ClientRuntime 2.3.24, the patched version, at theMicrosoft.IdentityModel.KeyVaultExtensionsproduction dependency boundary. Version 2.3.24 satisfiesMicrosoft.Azure.KeyVault's declared[2.3.11, 3.0.0)range and propagates to the dependent KeyVault test and package graphs.Changes
MicrosoftRestClientRuntimeVersion=2.3.24.Microsoft.Rest.ClientRuntimepackage reference toMicrosoft.IdentityModel.KeyVaultExtensions.Validation
Reproduced the original failure on merged
dev5xusing the package-feed proxy.Validated the exact solution-wide pack shape with audit enabled:
Result: succeeded and created the 5.7.2 packages.
Resolved dependency:
The generated
Microsoft.IdentityModel.KeyVaultExtensions.5.7.2.nupkgdeclaresMicrosoft.Rest.ClientRuntime 2.3.24for its target frameworks.Affected tests:
Fixes the NU1902 failure caused by GHSA-whph-446h-6m9v.