Repository navigation
Fix expired test tokens and remove external URL dependencies (5.x) - #3495
Merged
Ignacio Inglese (iNinja) merged 1 commit intoMay 20, 2026
Merged
Conversation
Update test infrastructure to handle hardcoded token expiry dates that are now in the past. Add ValidateLifetime = false where tests are not exercising lifetime validation. Replace external URL dependencies in ConfigurationManager tests with a local document retriever to prevent flaky failures from network-dependent assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ievgen Polyvanyi (cpp11nullptr)
approved these changes
May 19, 2026
Peter (pmaytak)
approved these changes
May 19, 2026
Kelly🌠 (kllysng)
approved these changes
May 19, 2026
This was referenced Jul 24, 2026
Closed
Closed
This was referenced Sep 21, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates test infrastructure on the 5.x servicing branch to restore CI green state.
Changes
ValidateLifetime = falseto test theory data where tests are not exercising lifetime validation (expiredDefault.ExpiresStringfrom March 2025)UseSecurityTokenDescriptorPropertiestest cases to 2040someaddress.com,httpstat.us/429) inConfigurationManagerTests.GetConfigurationwith a localExceptionThrowingDocumentRetrieverto eliminate flaky network-dependent failuresTest results