[cherry pick] Use TokenValidationParameter copy constructor to make a deep copy #3488
Merged
Conversation
westin-m
changed the title
kllysng
approved these changes
May 13, 2026
saurabhsathe-ms
approved these changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Cherry-picks a fix for Bug 3423710 by updating TokenValidationParameters.Clone()/copy-constructor behavior so cloned instances don’t share mutable collection state with the original, and updates tests/docs accordingly.
Changes:
- Deep-copies collection properties in the
TokenValidationParameters(TokenValidationParameters other)copy constructor (lists/dictionaries). - Updates
Clone()implementation and XML documentation to reflect the intended clone semantics. - Extends
TokenValidationParametersTests.Clone()with additional assertions around clone independence.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Microsoft.IdentityModel.Tokens/TokenValidationParameters.cs |
Updates the copy constructor and clone docs/implementation to avoid sharing mutable collections between original and clone. |
test/Microsoft.IdentityModel.Tokens.Tests/TokenValidationParametersTests.cs |
Updates clone test expectations; should validate collection deep-copy behavior. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Jun 2, 2026
Bump Microsoft.IdentityModel.JsonWebTokens from 8.18.0 to 8.19.0
Azure-Samples/azure-finops-agent#39
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry picks the fix for Bug 3423710: TokenValidationParameters.Clone does not make a deep copy