Extensibility Testing: Refactor #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and ensure GetException sets the ValidationError parameter required to provide a stack trace
…en comparing validation errors
…r extensibility testing. Renamed custom issuer validation delegates file to split the other validation aspects
…ifying the approach using the issuer extensibility tests as template
keegan-caruso
approved these changes
Nov 19, 2024
src/Microsoft.IdentityModel.Tokens.Saml/Saml/Exceptions/SamlValidationError.cs
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/LifetimeValidationError.cs
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/ValidationError.cs
Show resolved
Hide resolved
JoshLozensky
approved these changes
Nov 21, 2024
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/AudienceValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/AudienceValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/IssuerValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/IssuerValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/LifetimeValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/LifetimeValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/LifetimeValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/TokenTypeValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/ValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/ValidationError.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Validators.IssuerSigningKey.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Validators.IssuerSigningKey.cs
Outdated
Show resolved
Hide resolved
…m/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet into iinglese/extensibility-tests-base
This was referenced Nov 19, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.15.0
statisticssweden/PxWeb#772
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensibility Testing: Refactor
ValidationErrorand its subclasses to align optional parameters and ensure theGetExceptionmethod sets theValidationErrorparameter required to provide a stack trace.ValidationErrorparameters and updates the identity comparer to check for the exception's stack trace when comparing validation errors.Note: most of the files changed are due to the updated parameter order in ValidationError and subclasses.
Part of #2711