-
Notifications
You must be signed in to change notification settings - Fork 439
Update cgmanifest to align with the JSON schema #2969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI after merging dotnet/runtime#109453 with the same change, I dug in to understand why/how the component governance integration was still working despite the JSON document not adhering to the schema. I was able to confirm that it was working before, and it's still working after this change. The reason it worked is that the component detection that processes these files has the JSON deserialization set up where it is recognizing either TitleCase or properCase property names. So while it was working before, we're now adhering to the schema correctly and we won't get tripped up if the component detection ever applies stricter validation of the documents. |
With dotnet/machinelearning#7283, we realized that the
cgmanifest.jsonfile was not aligned with the JSON schema. It is using Title case property names but it should be using camelCase property names. See this comment for more detail: dotnet/machinelearning#7283 (comment)I'm following up by updating each CG manifest in the dotnet org where we had the same issue, and this match was found at https://github.com/dotnet/dotnet/blob/main/src/source-build-externals/src/azure-activedirectory-identitymodel-extensions-for-dotnet/build/cgmanifest.json.
Here's the console app I used to confirm the existing manifest isn't valid against its schema, and the updated one in this PR is valid:
Here's the output: