Skip to content

Conversation

@iNinja
Copy link
Contributor

@iNinja iNinja commented Sep 9, 2024

Added ArgumentNullException type with ValidationError

  • Added ISecurityTokenException interface to align system exceptions and custom exceptions under a single entry point to inject the validation error used to return the stack traces.
  • Added SecurityTokenArgumentNullException implementing the interface.
  • Updated usage of ArgumentNullException in code and tests to consume the new type.

Part of #2711

@iNinja iNinja requested a review from a team as a code owner September 9, 2024 18:41
…nerror

# Conflicts:
#	src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/ValidationError.cs
Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fill out the one comment, otherwise looks good.

@iNinja iNinja merged commit 79974de into dev Sep 13, 2024
@iNinja iNinja deleted the iinglese/argumentnullexception-with-validationerror branch November 15, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants