Re-factor Issuer Validator to Follow New Validation Model #2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNinja
previously approved these changes
Aug 1, 2024
Contributor
iNinja
left a comment
iNinja
left a comment
There was a problem hiding this comment.
Minor change and we're good.
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Issuer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs
Outdated
Show resolved
Hide resolved
brentschmaltz
previously requested changes
Aug 1, 2024
Contributor
brentschmaltz
left a comment
brentschmaltz
left a comment
There was a problem hiding this comment.
Properties that return IList should not be settable.
If the property can be null, for a successful validation, use a delayed creation.
Co-authored-by: Ignacio Inglese <[email protected]>
FuPingFranco
dismissed
brentschmaltz’s stale review
Changes have been made, need to dismiss review in order to unblock other work.
iNinja
approved these changes
Aug 6, 2024
SaurabhMSFT
approved these changes
Aug 6, 2024
This was referenced Aug 6, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.0
statisticssweden/PxWeb#693
Closed
This was referenced Aug 15, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.1
statisticssweden/PxWeb#706
Closed
This was referenced Oct 27, 2025
Open
This was referenced Nov 19, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.15.0
statisticssweden/PxWeb#772
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-factor Issuer Validator to Follow New Validation Model
Description
ValidIssuerfrom Issuer validation.TokenValidationParametersin favor of the newValidationParameters.