Skip to content

Token Type validation: Remove exceptions #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2024
Merged

Token Type validation: Remove exceptions #2688

merged 3 commits into from
Jul 9, 2024

Conversation

@FuPingFranco
Copy link
Contributor

@FuPingFranco FuPingFranco commented Jul 8, 2024

Token Type validation: Remove exceptions

Description

  • Implemented new (internal momentarily) method for token type validation which replaces exception throwing with a return of the new TokenTypeValidationResult containing the exception information.
  • Added tests around all the previous cases.

@FuPingFranco FuPingFranco requested a review from a team as a code owner July 8, 2024 22:56
iNinja
iNinja approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@iNinja iNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FuPingFranco FuPingFranco merged commit 1dd1e98 into dev Jul 9, 2024
@jennyf19 jennyf19 mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iNinja iNinja iNinja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FuPingFranco @iNinja