Move virtual methods to public in Signature Provider#2497
Merged
Conversation
These methods need to be moved to public so that the extensibility story works for user provider signature providers.
HarmanDhunna
approved these changes
Feb 24, 2024
jmprieur
approved these changes
Feb 26, 2024
jmprieur
left a comment
jmprieur
left a comment
Contributor
There was a problem hiding this comment.
Lgtm
Thanks @keegan-caruso
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods need to be moved to public
so that the extensibility story works for user provider signature providers.
related to #2418