Skip to content

Replace AssemblyVersion with Version#2494

Merged
FuPingFranco merged 4 commits into
devfrom
francofung/ReplaceAssemblyVersionWithVersion
Feb 23, 2024
Merged

Replace AssemblyVersion with Version#2494
FuPingFranco merged 4 commits into
devfrom
francofung/ReplaceAssemblyVersionWithVersion

Conversation

@FuPingFranco

@FuPingFranco FuPingFranco commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

Description

Replace dependency on updateAssemblyInfo.ps1 with Version property and ADO variables. In order to bring our build and release experience across our repos to a unified process, we need to adopt the way versioning is done our other repos.

Test runs:

WisonVersion = ' ' (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1257450&view=artifacts&pathAsName=false&type=publishedArtifacts )

WisonVersion = 7.3.3-preview-test-123 (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1257449&view=artifacts&pathAsName=false&type=publishedArtifacts)

WisonVersion = 7.3.3 (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1257451&view=artifacts&pathAsName=false&type=publishedArtifacts)

Fixes #2393

@jmprieur jmprieur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FuPingFranco
This looks good.

I think you can still update the github flow, and remove the pack.ps1 script and the buildconfiguration.xml file.

Did you update the process?

Comment thread buildConfiguration.xml
Comment thread .github/workflows/dotnetcore.yml Outdated
@FuPingFranco

FuPingFranco commented Feb 23, 2024

Copy link
Copy Markdown
Contributor Author

Thanks @FuPingFranco This looks good.

I think you can still update the github flow, and remove the pack.ps1 script and the buildconfiguration.xml file.

Did you update the process?

I updated the github flow and created a separate task to look into all scripts post this changes. Also, working on documentation on the process and will share it asap. Thank you for all the help @jmprieur :)

@jmprieur jmprieur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.
Thanks @FuPingFranco
Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Pin IdentityModel version for own dependencies

2 participants