Adding P50, P90 and P100 percentiles to benchmarks#2411
Merged
Conversation
| namespace Microsoft.IdentityModel.Benchmarks | ||
| { | ||
| // Define custom columns for P50 and P99 latency | ||
| public class P50Column : IColumn |
Contributor
There was a problem hiding this comment.
https://benchmarkdotnet.org/articles/features/statistics.html
Most of these look like they already exist in StatisticColumn?
Contributor
Author
There was a problem hiding this comment.
Right. The columns explicitly get the ones we want and not the others
keegan-caruso
approved these changes
Nov 21, 2023
keegan-caruso
left a comment
Contributor
There was a problem hiding this comment.
Few comments are off, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding P50, P90 and P100 percentiles to benchmarks
Adds 3 columns to the benchmark summaries to display the P50, P90 and P100 percentiles
Description
The benchmark summaries now contains the pecentiles
Fixes #2410