Fixed bug on case-insensitive properties on OpenIdConnectConfigurationSerializer.cs

[stvkouvaris]

Bug fix on case-insensitive property deserialization on OpenIdConnectConfigurationSerializer.cs

Fixes #2402

The json reader was getting out of sync after line 289
string propertyName = JsonPrimitives.ReadPropertyName(ref reader, OpenIdConnectConfiguration.ClassName, true);
inside the else statement that is handling case-insensitive property deserialization.

Removing the read: true parameter from all following json property reads, resolves the issue.

[stvkouvaris]

@microsoft-github-policy-service agree

[keegan-caruso]

@stvkouvaris would you be willing to add some tests for this?

[davek-dev]

This is causing an issue for me as well, was it supposed to get into yesterday's release? The PR looks good to me.

[jennyf19]

This is causing an issue for me as well, was it supposed to get into yesterday's release? The PR looks good to me.

We need a bit more time to review it @davek-dev and it will go in the 7.2.1 release (end of month or sooner).

[jennyf19]

[brentschmaltz]

Reviewing....

[keegan-caruso]

LGTM

[stvkouvaris]

@jennyf19 I can see that the issue was fixed on 7.3.1 release, however without this pull request getting merged to the main branch. Will it be merged on 7.3.2? Or is this now unnecessary?

[brentschmaltz]

@stvkouvaris We had to make a change in the serialization model to ensure that the entire Json Token was read and position the reader on the next token.

This PR (#2491).
We incorporated your ideas into that PR.

[brentschmaltz]

We have used the ideas here in this PR: #2491

And extended the fixes to JsonWebTokens, JsonWebKey and JsonWebKeySet.

[brentschmaltz]

We have used the ideas here in this PR: #2491

And extended the fixes to JsonWebTokens, JsonWebKey and JsonWebKeySet.