Fix the upgrade for eslint 9.17.0. #1159
Open
+1,300
−890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsinnit
force-pushed
the
fix/eslint-9.17.0
branch
5 times, most recently
from
08776f7 to
d376fe3
Compare
Tatsinnit
force-pushed
the
fix/eslint-9.17.0
branch
from
d376fe3 to
d4a6bfe
Compare
tejhan
approved these changes
Jan 8, 2025
Tatsinnit
requested review from
qpetraroia,
ReinierCC,
hsubramanianaks and
Copilot
There was a problem hiding this comment.
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- webview-ui/package.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #1132
Opening this PR to check if all checks will pass. 👮♂️
very early checkin, but we should also check after removing
cjsfiles as those must be redundant now.thanks. and ❤️ cc: @tejhan , @ReinierCC , @hsubramanianaks