Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] support new typespec emitter naming rule #947

Merged
merged 2 commits into from
Jun 4, 2024
Merged

[tcgc] support new typespec emitter naming rule #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c6233
support new typespec emitter naming rule
tadelesh Jun 3, 2024
aae343f
format and changelog
tadelesh Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/emitter_name-2024-5-3-22-57-49.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@azure-tools/typespec-client-generator-core"
---

support new typespec emitter naming rule
2 changes: 1 addition & 1 deletion packages/typespec-client-generator-core/src/internal-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function parseEmitterName(
);
return diagnostics.wrap("none");
}
const regex = /(?:cadl|typespec)-([^\\/]*)/;
const regex = /(?:cadl|typespec|client|server)-([^\\/-]*)/;
const match = emitterName.match(regex);
if (!match || match.length < 2) return diagnostics.wrap("none");
const language = match[1];
Expand Down
13 changes: 13 additions & 0 deletions packages/typespec-client-generator-core/test/internal-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,17 @@ describe("typespec-client-generator-core: internal-utils", () => {
strictEqual(docHelper.details, "This is a description");
});
});
describe("parseEmitterName", () => {
it("@azure-tools/typespec-{language}", async () => {
const runner = await createSdkTestRunner({ emitterName: "@azure-tools/typespec-csharp" });
await runner.compile("");
strictEqual(runner.context.emitterName, "csharp");
});

it("@typespec/{protocol}-{client|server}-{language}-generator", async () => {
const runner = await createSdkTestRunner({ emitterName: "@typespec/http-client-csharp" });
await runner.compile("");
strictEqual(runner.context.emitterName, "csharp");
});
});
});
Loading