Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] default .access to "public" #925

Merged
merged 5 commits into from
May 31, 2024
Merged

[tcgc] default .access to "public" #925

merged 5 commits into from
May 31, 2024

Conversation

iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented May 28, 2024 •
edited
Loading

fixes #926

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 28, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - breaking ✏️

change default of .access on a model or enum to "public" instead of undefined

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/925/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/925/

@haolingdong-msft
Copy link
Member

Could we consider the anonymous model used in spread parameter in operation case? In this case, the model should be internal as users cannot see it. e.g.

  @post
  sendLong(
    ...LongRequest
  ): OkResponse;

Here SendLongRequest will be anonymous model and the access should be internal as it is not visible to user.

@iscai-msft
Copy link
Contributor Author

@haolingdong-msft @tadelesh is handling that in this PR

@iscai-msft iscai-msft requested a review from m-nash May 29, 2024 15:41
@iscai-msft iscai-msft enabled auto-merge May 31, 2024 16:45
@iscai-msft iscai-msft added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 884d68b May 31, 2024
21 checks passed
@iscai-msft iscai-msft deleted the default_access_public branch May 31, 2024 17:09
This was referenced Jul 5, 2024
Closed
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 20, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 20, 2024
Merged
This was referenced Jul 28, 2024
Merged
Merged
@tadelesh tadelesh mentioned this pull request Aug 15, 2024
Merged
tadelesh added a commit that referenced this pull request Aug 15, 2024
@tadelesh
[tcgc] no need to add access override along with usage override for o…
b02eabc 
…rphan model (#1378)

this should be a bug that missing in
#925.
since we changed access default to public, we no longer need to add
access override along with usage override when we want to expose an
orphan model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archerzz archerzz archerzz left review comments

@m-nash m-nash m-nash approved these changes

@joheredi joheredi joheredi approved these changes

@srnagar srnagar srnagar approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tcgc] default .access to "public" instead of undefined
8 participants
@iscai-msft @azure-sdk @haolingdong-msft @archerzz @joheredi @srnagar @m-nash @tadelesh