Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @azure-tools/typespec-azure-core/non-breaking-versioning should actually be part of resource-manger #906

Merged
merged 2 commits into from
May 22, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented May 22, 2024

Wrongly removed from both ruleset previously but the previous behavior of typespec-resource-manager/all was to have it included.

@timotheeguerin timotheeguerin changed the title Fix Fix @azure-tools/typespec-azure-core/non-breaking-versioning should actually be part of resource-manger May 22, 2024
@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

  • @azure-tools/typespec-azure-rulesets
Show changes

@azure-tools/typespec-azure-rulesets - fix ✏️

Add @azure-tools/typespec-azure-core/non-breaking-versioning back into resource-manager ruleset

@azure-sdk
Copy link
Collaborator

@timotheeguerin timotheeguerin added this pull request to the merge queue May 22, 2024
Merged via the queue into Azure:main with commit 4be1916 May 22, 2024
21 checks passed
@timotheeguerin timotheeguerin deleted the fix/non-breaking-versioning branch May 22, 2024 21:58
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
…` should actually be part of resource-manger" (#908)

Reverts #906

Rule wasn’t actually enabled in the ruleset extended so this was correct
before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants