Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-generic-numeric rule to disable LintDiff IntegerTypeMustHaveFormat #619

Merged
merged 10 commits into from
Apr 18, 2024

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Apr 5, 2024

Closes #669.

REST API Specs
Azure/azure-rest-api-specs#28731

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 5, 2024

All changed packages have been documented.

  • @azure-tools/typespec-azure-core
Show changes

@azure-tools/typespec-azure-core - fix ✏️

Add no-generic-numeric rule to disable LintDiff IntegerTypeMustHaveFormat

@azure-sdk
Copy link
Collaborator

@tjprescott tjprescott force-pushed the core/IntegerTypesRule branch 4 times, most recently from 2f35891 to a710224 Compare April 8, 2024 20:23
@tjprescott tjprescott changed the title Add use-standard-integer rule to disable LintDiff IntegerTypeMustHaveFormat Add no-generic-type rule to disable LintDiff IntegerTypeMustHaveFormat Apr 10, 2024
@tjprescott tjprescott changed the title Add no-generic-type rule to disable LintDiff IntegerTypeMustHaveFormat Add no-generic-numeric rule to disable LintDiff IntegerTypeMustHaveFormat Apr 10, 2024
@markcowl
Copy link
Member

Fixes: #669

@tjprescott tjprescott marked this pull request as ready for review April 15, 2024 19:58
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this looks good just to figure out if we want a codefix or not

@tjprescott tjprescott added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit a5d144e Apr 18, 2024
21 checks passed
@tjprescott tjprescott deleted the core/IntegerTypesRule branch April 18, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{Linting]: Discourage use of imprecise numeric types in Azure.Core and Azure.ResourceManager
5 participants