Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] create endpoint type #474

Merged
merged 5 commits into from
Mar 22, 2024
Merged

[tcgc] create endpoint type #474

merged 5 commits into from
Mar 22, 2024

Conversation

iscai-msft
Copy link
Contributor

No description provided.

@iscai-msft iscai-msft mentioned this pull request Mar 21, 2024
Closed
17 tasks
@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

srnagar
srnagar approved these changes Mar 21, 2024
View reviewed changes
packages/typespec-client-generator-core/src/package.ts Outdated
Comment on lines 57 to 58
<<<<<<< HEAD
=======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this

packages/typespec-client-generator-core/src/package.ts Outdated
isNullable,
updateWithApiVersionInformation,
>>>>>>> e004ce95f2b624b37c207f04e447bd77af63ab6a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this

@iscai-msft iscai-msft enabled auto-merge (squash) March 22, 2024 18:02
@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/474/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/474/

@iscai-msft iscai-msft merged commit 63bbe2f into main Mar 22, 2024
14 checks passed
@iscai-msft iscai-msft deleted the endpoint_design branch March 22, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iscai-msft @azure-sdk @srnagar