Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] add UsageFlags.JsonMergePatch #455

Merged
merged 9 commits into from
Mar 22, 2024
Merged

[tcgc] add UsageFlags.JsonMergePatch #455

merged 9 commits into from
Mar 22, 2024
+48 −6

Conversation

iscai-msft
Copy link
Contributor

No description provided.

@iscai-msft iscai-msft mentioned this pull request Mar 20, 2024
Closed
17 tasks
@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/455/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/455/

@tadelesh
Copy link
Member

tadelesh commented Mar 21, 2024 •
edited
Loading

I'd like to hold this PR before we could meet all requirements from Java and .NET from this issue. Besides, I don't like the patch usage. It is not orthometric with input.

@iscai-msft
Copy link
Contributor Author

@tadelesh confirmed with the rest of the dpg crew that we want a JsonMergePatch usage. A good amount of languages generate extra info for the model in that case. We will still mark it as Input, so they're is no rule that both can't be set

@iscai-msft iscai-msft changed the title [tcgc] add UsageFlags.Patch [tcgc] add UsageFlags.JsonMergePatch Mar 22, 2024
@iscai-msft iscai-msft enabled auto-merge (squash) March 22, 2024 19:19
@iscai-msft iscai-msft merged commit 76cd217 into main Mar 22, 2024
14 checks passed
@iscai-msft iscai-msft deleted the move_patch_to_usage branch March 22, 2024 21:29
@tadelesh tadelesh mentioned this pull request Mar 25, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joheredi joheredi joheredi approved these changes

@srnagar srnagar srnagar approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iscai-msft @azure-sdk @tadelesh @joheredi @srnagar