Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] make artifical content type parameter optional #425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iscai-msft
Copy link
Contributor

Since it wasn't defined in the tsp, we can't assume that it's required on the service. Should default to optional. If it's required, it should be explicitly defined in the tsp

@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

@@ -175,13 +175,15 @@ function createContentTypeOrAcceptHeader(
};
}
// No need for clientDefaultValue because it's a constant, it only has one value
// Since these are the created accept and content type header parameters, we don't make them required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for this change? Since these are synthesized, constant, params, they won't show up in public surface area so there's no way for callers to set them. Maybe I'm missing something.

@azure-sdk
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants