Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing canonical-versioning ruleset in arm lib #317

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Fix missing canonical-versioning ruleset in arm lib #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1202b3a
Fix missing fix/missing-canonical-versioning ruleset
timotheeguerin Feb 26, 2024
3fc9d80
Create fix-missing-canonical-versioning-2024-1-26-22-11-28.md
timotheeguerin Feb 26, 2024
acef709
Merge branch 'main' into fix/missing-canonical-versioning
timotheeguerin Feb 26, 2024
f0fb407
Merge branch 'main' of https://github.com/Azure/typespec-azure into f…
timotheeguerin Feb 29, 2024
705b122
mnerge
timotheeguerin Feb 29, 2024
f913056
revert core
timotheeguerin Feb 29, 2024
a158197
Merge branch 'main' into fix/missing-canonical-versioning
timotheeguerin Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/fix-missing-canonical-versioning-2024-1-26-22-11-28.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: feature
packages:
- "@azure-tools/typespec-azure-resource-manager"
---

Add ruleset `canonical-versioning` to Azure Resource Manager library.
5 changes: 4 additions & 1 deletion packages/typespec-azure-resource-manager/src/linter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ export const $linter = defineLinter({
rules,
ruleSets: {
all: {
extends: [
"@azure-tools/typespec-azure-core/all",
"@azure-tools/typespec-azure-core/canonical-versioning",
],
enable: {
...allRulesEnabled,
// TODO: Enable this rule once azure-rest-api-specs repo is ready (issue #3839)
Expand All @@ -70,7 +74,6 @@ export const $linter = defineLinter({
[`@azure-tools/typespec-azure-core/bad-record-type`]:
"This clashes with the ARM `no-record` rule.",
},
extends: ["@azure-tools/typespec-azure-core/all"],
},
},
});
Loading