Skip to content

update location type to azureLocation#2921

Closed
live1206 wants to merge 21 commits intoAzure:mainfrom
live1206:azure-location
Closed

update location type to azureLocation#2921
live1206 wants to merge 21 commits intoAzure:mainfrom
live1206:azure-location

Conversation

@live1206
Copy link
Member

@live1206 live1206 commented Jul 1, 2025

location in TrackedResource should be azureLocation
This change is follow-up for #1138, we just found more cases.

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Jul 1, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 1, 2025

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - fix ✏️

location in TrackedResource should be azureLocation instead of string.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 1, 2025

You can try these changes here

🛝 Playground 🌐 Website

@live1206
Copy link
Member Author

live1206 commented Jul 2, 2025

Linked the work items in the PR description.
@timotheeguerin Please take a review at this.

@timotheeguerin timotheeguerin added the int:azure-specs Run integration tests against azure-rest-api-specs label Jul 10, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 30, 2025

Open in StackBlitz

npm i https://pkg.pr.new/Azure/typespec-azure/@azure-tools/typespec-azure-resource-manager@2921

commit: 3eec30a

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things remain for this PR:

  • Fix the merge conflict in your draft pr against typespec-next
  • Create a draft PR against the 'RPSaaSMaster' branch of azure-rest-api-specs-pr, validate that it passes TypeSpec validation (or fix any failures) and link it here.

Otherwise, this looks perfect

@live1206
Copy link
Member Author

live1206 commented Aug 8, 2025

create #3138 instead to have a sooner release

@markcowl
Copy link
Member

new pr is here: #3176

@markcowl markcowl linked an issue Aug 20, 2025 that may be closed by this pull request
4 tasks
@markcowl
Copy link
Member

this was already released

@markcowl markcowl closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

int:azure-specs Run integration tests against azure-rest-api-specs lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants