Support new added @flattenProperty decorator in autorest emitter
#277
Conversation
tadelesh
requested review from
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented. |
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/277/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/277/ |
There was a problem hiding this comment.
Do we expect this decorator to be added in the main files or client.tsp? As if it is in the client.tsp it won't get picked up by autorest today.
There was a problem hiding this comment.
It should be in client.tsp. Is there any blocking that we could not change autorest emitter's compile enter point to client.tsp?
There was a problem hiding this comment.
I think that defeats the point of the separate client.tsp. However i have always been of the opinion that client.tsp should be imported from main
There was a problem hiding this comment.
Since swagger contains not only the API definition but also some client related information, I think autorest emitter compile from client.tsp is reasonable.
There was a problem hiding this comment.
It is but then why do we have a different entry point, this separation is just for the spec repo, we should just import client.tsp from main.
There was a problem hiding this comment.
Oh, if that is the only reason for import main from client, then it is non-sense. I stand for import client from main which makes the entry point to be one.
Co-authored-by: Timothee Guerin <[email protected]>
Co-authored-by: Timothee Guerin <[email protected]>
resolve: #276