[tcgc] Remove deprecated description details #1560
Open
+12
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
iscai-msft
commented
Sep 18, 2024
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| changeKind: deprecation | |||
There was a problem hiding this comment.
should this be marked deprecation or just bug fix since we deprecated it in a previous version
There was a problem hiding this comment.
i label it with breaking change in previous pr.
iscai-msft
commented
Sep 18, 2024
iscai-msft
commented
Sep 18, 2024
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
tadelesh
approved these changes
Sep 19, 2024
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| changeKind: deprecation | |||
There was a problem hiding this comment.
i label it with breaking change in previous pr.
| @@ -354,7 +354,7 @@ function handleHttpResponse( | |||
| } as SdkHttpResponseExample; | |||
| if (typeof example === "object" && example !== null) { | |||
| for (const name of Object.keys(example)) { | |||
| if (name === "description") { | |||
| if (name === "doc") { | |||
There was a problem hiding this comment.
it is a hard coded property in current json example, no need to change it to doc.
added 2 commits
September 19, 2024 11:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1386