Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TCGC] Fix judge logic how to distinguish model is referred both in common content-type and multipart content-type #1511

Merged
merged 13 commits into from
Sep 20, 2024
Merged

[TCGC] Fix judge logic how to distinguish model is referred both in common content-type and multipart content-type #1511

merged 13 commits into from
Sep 20, 2024

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Sep 11, 2024

fix #1510

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Sep 11, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 11, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

Fix logic to check conflicting usage for model of multipart body and regular body

@msyyc msyyc changed the title Fix judge logic how to distinguish model is referred both in common content-type and multipart content-type [TCGC] Fix judge logic how to distinguish model is referred both in common content-type and multipart content-type Sep 11, 2024
@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@msyyc msyyc marked this pull request as ready for review September 13, 2024 05:38
@tadelesh tadelesh added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 3becc74 Sep 20, 2024
22 checks passed
@tadelesh tadelesh deleted the fix-multipart-diagnostics branch September 20, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh left review comments

@iscai-msft iscai-msft iscai-msft approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TCGC reports wrong diagnostics "conflicting-multipart-model-usage" for valid multipart cases
5 participants
@msyyc @azure-sdk @tadelesh @iscai-msft @weidongxu-microsoft