Add networksecurityperimeter and managedidentitywithdelegation common types

[AlitzelMendez]

issue: #1160

[azure-sdk]

All changed packages have been documented.

• ✅ @azure-tools/typespec-azure-resource-manager

Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

Added common-types managed identity with delegation and network security perimeter

[timotheeguerin]

This wasn't there before

[AlitzelMendez]

I tried to address this one but I am unsure if it is a problem on my definition or when the generation of the common types is happening.

For what I saw, "x-ms-identifiers" is included when there is not an id for the array, in this case there is an id coming from resource:

typespec-azure/packages/typespec-azure-resource-manager/lib/common-types/network-security-perimeter.tsp

Line 170 in 80f5576

model NetworkSecurityPerimeterConfiguration extends ProxyResource {

(is not directly in there but it is pulled) even if I tried to add an id, I am not able to do so because it is already inherited from the other model, but when the common-type is getting generated it includes the x-ms-identifiers like it didn't have the id, am I missing something?

[markcowl]

I think this is related to this bug: #1358 as the same logic is likely to be used

If so, we probably want to fix this before we merge this PR

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	📚 Next docs

[markcowl]

We need to decide how to handle the segment name in this parameter model. We might wanto to do this: #1358

Or there may be a static value that is always be used. This depends on usage inside specs

[AlitzelMendez]

Mark, I think that is the link for the bug that you mentioned above, could you please share the link for the suggestion?

[markcowl]

Yes, I meant a template, like this:

typespec-azure/packages/typespec-azure-resource-manager/lib/common-types/private-links.tsp

Lines 117 to 127 in 95cc6b9

	/**
	* The name of the private endpoint connection associated with the Azure resource.
	* @template Segment The resource type name for private endpoint connections (default is privateEndpointConnections)
	*/
	model PrivateEndpointConnectionParameter<Segment extends valueof string = "privateEndpointConnections"> {
	/** The name of the private endpoint connection associated with the Azure resource. */
	@path
	@TypeSpec.Rest.segment(Segment)
	@key("privateEndpointConnectionName")
	name: string;
	}

[markcowl]

Yes, I meant a template, like this:

typespec-azure/packages/typespec-azure-resource-manager/lib/common-types/private-links.tsp

Lines 117 to 127 in 95cc6b9

	/**
	* The name of the private endpoint connection associated with the Azure resource.
	* @template Segment The resource type name for private endpoint connections (default is privateEndpointConnections)
	*/
	model PrivateEndpointConnectionParameter<Segment extends valueof string = "privateEndpointConnections"> {
	/** The name of the private endpoint connection associated with the Azure resource. */
	@path
	@TypeSpec.Rest.segment(Segment)
	@key("privateEndpointConnectionName")
	name: string;
	}

[markcowl]

Approved pending resolution of the two remaining issues