Autorest respect clientName in more places #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
chrisradek
approved these changes
Aug 30, 2024
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Sep 7, 2024
fix [Azure#442](Azure#442) `@clientName` is respected for: - definition names - enum values names - parameters names(for body it replace the `name` for other it adds `x-ms-client-name`) Doing this now as this will help getting rid of some use of `@extension` This makes this doc accurate now https://azure.github.io/typespec-azure/docs/next/migrate-swagger/faq/breakingchange#createorupdate-put-apis as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #442
@clientNameis respected for:namefor other it addsx-ms-client-name)Doing this now as this will help getting rid of some use of
@extensionThis makes this doc accurate now https://azure.github.io/typespec-azure/docs/next/migrate-swagger/faq/breakingchange#createorupdate-put-apis as well