Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCGC, make content type optional when request body is optional #1452

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

haolingdong-msft
Copy link
Member

Fix #1259

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Aug 30, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 30, 2024

All changed packages have been documented.

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

TCGC, make content type optional when request body is optional

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@haolingdong-msft haolingdong-msft added this pull request to the merge queue Sep 2, 2024
Merged via the queue into Azure:main with commit d9b2b5d Sep 2, 2024
22 checks passed
@haolingdong-msft haolingdong-msft deleted the optional-content-type branch September 2, 2024 09:18
@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Sep 3, 2024

Could you notify on LLC channel to Shanghai devs?

I assume there is going to be behavior changes on TCGC and hence affect their emitter code.

markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TCGC][Bug] TCGC added content-type header should be optional if request body is optional
5 participants