[tcgc] don't require core-introduced params with @override
#1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2024 13:04
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
tadelesh
reviewed
Aug 28, 2024
srnagar
approved these changes
Aug 28, 2024
tadelesh
approved these changes
Aug 29, 2024
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Sep 7, 2024
) With `@override`, we require a 1:1 mapping between the actual parameters and the parameters passed in your method signature override. However, this causes issues with `core`-introduced parameters because of template-related issues. On a higher level though, I think it's fair to not require `core` params in the method signature, since we already hide these parameters in the method signature, and these parameters will still be eventually set to the service cc @trangevi --------- Co-authored-by: iscai-msft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
@override, we require a 1:1 mapping between the actual parameters and the parameters passed in your method signature override. However, this causes issues withcore-introduced parameters because of template-related issues. On a higher level though, I think it's fair to not requirecoreparams in the method signature, since we already hide these parameters in the method signature, and these parameters will still be eventually set to the servicecc @trangevi