Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tcgc): set sdk method body parameter encode with http content type #1410

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

archerzz
Copy link
Member

  • after fetching the sdk method body parameter, reset its encode according to the underlying http request content-type
  • add unit test

fix #1084

- after fetching the sdk method body parameter, reset its encode according to the underlying http request content-type
- add unit test

fix Azure#1084
@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Aug 22, 2024
@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

set sdk method body parameter encode with http content type

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@archerzz archerzz added this pull request to the merge queue Aug 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2024
@iscai-msft iscai-msft added this pull request to the merge queue Aug 23, 2024
Merged via the queue into Azure:main with commit 9572cbe Aug 23, 2024
22 checks passed
@archerzz archerzz deleted the tcgc/sync-body-param-encode branch August 27, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][TCGC]: inconsistent encode between SdkMethodParameter and HttpOperationParameter
3 participants