Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] add optional generic parameters to SdkUnionType #1343

Merged
merged 3 commits into from
Aug 13, 2024
Merged

[tcgc] add optional generic parameters to SdkUnionType #1343

merged 3 commits into from
Aug 13, 2024

Conversation

iscai-msft
Copy link
Contributor

fixes #1274

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Aug 9, 2024
@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - feature ✏️

Add @hasJsonConverter for csharp only to indicate if JSON converter is needed

@azure-tools/typespec-client-generator-core - fix ✏️

Add generic parameter inputs to SdkUnionType to clearly define the union types of endpoint and credential params

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@iscai-msft iscai-msft merged commit cc94884 into release/august-2024 Aug 13, 2024
22 checks passed
@iscai-msft iscai-msft deleted the union_template_args branch August 13, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@MaryGao MaryGao MaryGao approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iscai-msft @azure-sdk @timotheeguerin @MaryGao